Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logs for multicontainer support #104

Merged
merged 1 commit into from
Jan 13, 2021
Merged

added logs for multicontainer support #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ActionInputValidator/Validations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ exports.packageNotAllowed = packageNotAllowed;
// Error if multi container config file is provided
function multiContainerNotAllowed(configFile) {
if (!!configFile) {
throw new Error("Multi container support is not available for windows containerized web app.");
throw new Error("Multi container support is not available for windows containerized web app or with publish profile.");
}
}
exports.multiContainerNotAllowed = multiContainerNotAllowed;
Expand Down
10 changes: 5 additions & 5 deletions src/ActionInputValidator/Validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function packageNotAllowed(apppackage: string) {
// Error if multi container config file is provided
export function multiContainerNotAllowed(configFile: string) {
if(!!configFile) {
throw new Error("Multi container support is not available for windows containerized web app.");
throw new Error("Multi container support is not available for windows containerized web app or with publish profile.");
}
}

Expand All @@ -70,10 +70,10 @@ export function validateSingleContainerInputs() {
export function validateContainerInputs() {

let actionParams: ActionParameters = ActionParameters.getActionParams();

actionParams.isMultiContainer = false;

if(!!actionParams.multiContainerConfigFile && exist(actionParams.multiContainerConfigFile)){
if(!!actionParams.multiContainerConfigFile && exist(actionParams.multiContainerConfigFile)){
let stats: fs.Stats = fs.statSync(actionParams.multiContainerConfigFile);
if(!stats.isFile()) {
throw new Error("Docker-compose file path is incorrect.");
Expand Down Expand Up @@ -102,9 +102,9 @@ export function validateContainerInputs() {
export async function validatePackageInput() {
let actionParams = ActionParameters.getActionParams();
actionParams.package = new Package(actionParams.packageInput);

// msbuild package deployment is not supported
let isMSBuildPackage = await actionParams.package.isMSBuildPackage();
let isMSBuildPackage = await actionParams.package.isMSBuildPackage();
if(isMSBuildPackage) {
throw new Error(`Deployment of msBuild generated package is not supported. Please change package format.`);
}
Expand Down