Add webview for connecting ACR to cluster #720
Conversation
peterbom
force-pushed
the
feature/connect-acr-webview
branch
from
6338575 to
168960a
Compare
This reverts commit 168960a.
There was a problem hiding this comment.
💡 Thank you for this PR. I assume this is necessary for the Draft Hook integration in the latest VSCode extension update.
-
I'll let @qpetraroia review them. If the decisions made between you and Quentin align U/X then worth to just get eyes, I'm happy to proceed.
-
It would be beneficial to document the next steps and any other upcoming changes.
Thank you, as always, to everyone for reviewing and contributing or even looking helping this work. Humble and kind fyi to @hsubramanianaks + @sprab + @gambtho for eyes.
There was a problem hiding this comment.
@peterbom Thanks for splitting up the PR, changes looks good overall. I would suggest getting feedback on the UX from Quentin/Ivelisse. Also some minor comments for others to understand. Thank you again.
* add webview for connecting ACR to cluster * remove test file to reduce PR size * Revert "remove test file to reduce PR size" [skip pr-size] This reverts commit 168960a. * Address PR comments [skip pr-size]
As #709 violates the PR size checker, this is the first part of two (I hope) smaller PRs to introduce the changes more gradually.
This part is just the webview, and can be run locally using the webview launch task. It looks like this:
It does not involve any functional changes to the compiled VS Code extension.