Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes for #682:
This helps prevent issues like #680 from arising in the future. It also makes the
AzureSessionProvider
interface more resistant to breakages by adding anOptions
parameter for session retrieval options that might grow in the future (e.g. to enable specifying extra graph API scopes or application client IDs).Design decisions:
selectedTenant
property that assumes the user would be able to silently obtain a token for that tenant.Opening as a draft since those decisions are debatable.EDIT: I discussed this further with @alexweininger (who authored the Azure authentication extension). Some notes:
AzureSessionProvider
interface currently manages two separate concerns which should probably be distinct:Longer term it would probably make sense to explicitly separate these out. But again, we should wait for further developments in the VS Code API first.