Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treeview stuck with only 'select tenant' node #681

Merged
merged 1 commit into from
May 20, 2024

Conversation

peterbom
Copy link
Contributor

Addresses #680

This is just to fix the observed behaviour that:

  1. The treeview can display a node saying 'select tenant' when in fact there's only one tenant to choose from; and
  2. The 'select tenant' command currently doesn't do anything if there is only a single tenant to choose from.

There are some additional changes we can make to the session provider API that should make this kind of defect less likely. I'll address those in a separate issue and PR.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me, very specific to the scenario. I could test it latter tonight. (Due to specific nature I believe this might have got missed from the tests done around this)

@peterbom
Copy link
Contributor Author

👍 looks good to me, very specific to the scenario. I could test it latter tonight. (Due to specific nature I believe this might have got missed from the tests done around this)

Thank you. I agree we wouldn't have tested this scenario - I'm actually unable to come up with concrete repro steps, as it involves simply not using the extension for an extended number of days (I don't know how many).

@Tatsinnit Tatsinnit merged commit 744f3b5 into Azure:main May 20, 2024
7 checks passed
tejhan pushed a commit to tejhan/vscode-aks-tools that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants