Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badge for codeql and chai test fix. #439

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Add badge for codeql and chai test fix. #439

merged 4 commits into from
Jan 20, 2024

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Jan 19, 2024 •
edited
Loading

PR is intending to update the readme with the codeql badge and the chai dependentbot update which has some quirks, given the chai x mocha dependencies.

Thanks heaps.

@Tatsinnit Tatsinnit added enhancement 🚀 New feature or request or improvements on existing code. dependencies Pull requests that update a dependency file investigating 🔍 labels Jan 19, 2024
@Tatsinnit Tatsinnit self-assigned this Jan 19, 2024
@Tatsinnit
CLean up.
cad05ae 
Signed-off-by: Tatsinnit <[email protected]>
@Tatsinnit
Clean up.
e566d9f 
Signed-off-by: Tatsinnit <[email protected]>
@Tatsinnit Tatsinnit requested a review from peterbom January 19, 2024 03:54
@Tatsinnit Tatsinnit force-pushed the add/badgeanddependabotfix branch from c62d175 to e566d9f Compare January 19, 2024 04:52
peterbom
peterbom approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@peterbom peterbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could probably cache the Promise (the result of import("chai")), but let's merge as it is for now, and we can look at further refactoring when we revisit this to add additional testing.

@Tatsinnit Tatsinnit merged commit bac9e0a into Azure:main Jan 20, 2024
10 checks passed
tejhan pushed a commit to tejhan/vscode-aks-tools that referenced this pull request Dec 4, 2024
@Tatsinnit
Add badge for codeql and chai test fix. (Azure#439)
36fc2fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbom peterbom peterbom approved these changes

Assignees

@Tatsinnit Tatsinnit

Labels
dependencies Pull requests that update a dependency file enhancement 🚀 New feature or request or improvements on existing code. investigating 🔍
Projects
AKS Extension Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tatsinnit @peterbom