Automatic Cluster handling for KAITO installation #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iled kaito installations
tejhan
added
Change of behaviour
tejhan
requested review from
Tatsinnit,
hsubramanianaks,
ReinierCC,
qpetraroia and
ivelisseca
ReinierCC
approved these changes
Jan 30, 2025
ivelisseca
approved these changes
Jan 30, 2025
Tatsinnit
reviewed
Jan 31, 2025
|
|
||
| // Prevent KAITO installation on automatic clusters | ||
| const skuName = currentJson.sku?.name; | ||
| if (skuName === "Automatic") { |
There was a problem hiding this comment.
💡 Thought Share only please: Regarding Automatic Can we please thing of making this Enum, if this has known types. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles attempted installation of KAITO on automatic clusters.
Context : Due to nrg lockdown & deny permissions of Automatic cluster, we are unable to create federated credentials in the node resource group. This is necessary for proper KAITO installation & due to the Automatic cluster SKU configuration, we are unable to change access / permissions to allow for such. Thus, I've added safeguards to prevent failed install on auto clusters alongside a message to the user.
Additionally, there have been some additions to the KAITO installation logic to terminate installation when errors do occur (were some cases where error would be caught but installation would continue). Also added conditional render to display error messages for failed installations.
.vsix for testing -> vscode-aks-tools-1.5.5-autokaito.vsix.zip