Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Setup for Automated Deployments (Panel & Webview) #1193

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

ReinierCC
Copy link
Collaborator

Putting this PR out with current state of feature development, before it becomes much more complex with full functionality.

Next PR will build out backend functionality on Panel to support UI design which is still being created.

Current functionality is NOT available to user.

@ReinierCC ReinierCC requested review from Copilot and tejhan January 22, 2025 17:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (9)
  • package.json: Language not supported
  • webview-ui/src/AutomatedDeployments/AutomatedDeployments.module.css: Language not supported
  • webview-ui/src/manualTest/main.tsx: Evaluated as low risk
  • src/commands/utils/acrs.ts: Evaluated as low risk
  • src/tree/aksClusterTreeItem.ts: Evaluated as low risk
  • webview-ui/src/main.tsx: Evaluated as low risk
  • src/webview-contract/webviewTypes.ts: Evaluated as low risk
  • src/extension.ts: Evaluated as low risk
  • webview-ui/src/AutomatedDeployments/AutomatedDeployments.tsx: Evaluated as low risk
Comments suppressed due to low confidence (4)

webview-ui/src/AutomatedDeployments/state.ts:102

  • The getGitHubReposRequest event handler does not update the state in any meaningful way. Consider setting a loading state or handling errors.
getGitHubReposRequest: (state) => ({ ...state, }),

webview-ui/src/AutomatedDeployments/state.ts:109

  • The setSelectedGitHubRepo event handler sets the state directly without any validation. Consider adding validation checks before updating the state.
setSelectedGitHubRepo: (state, repo) => ({ ...state, selectedGitHubRepo: repo, }),

webview-ui/src/AutomatedDeployments/state.ts:125

  • The setSelectedNamespace event handler sets the state directly without any validation. Consider adding validation checks before updating the state.
setSelectedNamespace: (state, namespace) => ({ ...state, selectedDeploymentNamespace: namespace, }),

src/webview-contract/webviewDefinitions/automatedDeployments.ts:7

  • [nitpick] Consider adding a type definition for the elements of the repos array to ensure consistency and avoid potential issues.
repos: string[];

src/panels/DevHubAutoDeployPanel.ts Show resolved Hide resolved
@Tatsinnit Tatsinnit added enhancement 🚀 New feature or request or improvements on existing code. UX labels Jan 22, 2025
Tatsinnit
Tatsinnit previously approved these changes Jan 22, 2025
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Looks good to me!! We have removed a key issue which was previously causing the dependency alert <3 Thanks heaps for this!!

Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine for boilerplate code, but left some minor comments. Hope this get's cleaned up in the upcoming PR's. Thank you Reinier.

@Tatsinnit Tatsinnit merged commit 001d0f0 into Azure:main Jan 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request or improvements on existing code. Incremental Build 🏗️ UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants