ARM: Add rule to allow disabling LintDiff AvoidAdditionalProperties
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changed packages have been documented. |
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/304/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/304/ |
tjprescott
force-pushed
the
AvoidAdditionalProperties
branch
3 times, most recently
from
0d6a563 to
fccb688
Compare
tjprescott
requested review from
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
packages/typespec-azure-resource-manager/src/rules/arm-no-record.ts
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/src/rules/arm-no-record.ts
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/test/rules/arm-no-record.test.ts
Outdated
Show resolved
Hide resolved
tjprescott
force-pushed
the
AvoidAdditionalProperties
branch
4 times, most recently
from
5ba9156 to
651f688
Compare
markcowl
requested changes
Feb 27, 2024
packages/typespec-azure-resource-manager/src/rules/arm-no-record.ts
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/src/rules/arm-no-record.ts
Outdated
Show resolved
Hide resolved
tjprescott
force-pushed
the
AvoidAdditionalProperties
branch
3 times, most recently
from
25318a5 to
fe00c65
Compare
markcowl
approved these changes
Feb 28, 2024
tjprescott
force-pushed
the
AvoidAdditionalProperties
branch
from
0fa510f to
889233c
Compare
tjprescott
force-pushed
the
AvoidAdditionalProperties
branch
from
889233c to
0438091
Compare
timotheeguerin
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Azure/typespec-azure-pr/issues/4083
Impact
14 violations in REST API Specs (Azure/azure-rest-api-specs#27926)
azure-openapi-validator
Azure/azure-openapi-validator#667