Adding typespec-azure-portal-core package #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yejee94
requested review from
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
! Conflicts: ! pnpm-lock.yaml
! Conflicts: ! pnpm-lock.yaml
…espec-azure into yejeelee/azurePortal ! Conflicts: ! pnpm-lock.yaml
There was a problem hiding this comment.
Does this package make sense to be used in the azure playground? If so, you should also update the playground config in packages/typespec-azure-playground-website/src/index.ts
There was a problem hiding this comment.
I think I should cover this in next iteration :) is that okay with you?
…espec-azure into yejeelee/azurePortal
| export * from "./keys.js"; | ||
| export { $lib } from "./lib.js"; | ||
| export * from "./types.js"; | ||
| export * from "./validate.js"; |
There was a problem hiding this comment.
Suggested change
| export * from "./validate.js"; | |
| export {$onValidate} from "./validate.js"; |
try to limit what you export as everything becomes public api for your package and change will break users
Double check for the other export * if you do actually want that
There was a problem hiding this comment.
ah! I see yes checked everything will be needed
timotheeguerin
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.