Add sdk emitters to arm template #1977
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes needing a change description found. |
maririos
commented
Dec 11, 2024
| enableOperationGroup: true | ||
| packageDetails: | ||
| name: "@azure/{{#normalizePackageName}}{{parameters.ServiceNamespace}}{{/normalizePackageName}}" | ||
| "@azure-tools/typespec-go": |
There was a problem hiding this comment.
@tadelesh could you verify?
maririos
commented
Dec 11, 2024
| clear-output-folder: true | ||
| model-namespace: false | ||
| namespace: "{package-dir}" | ||
| "@azure-tools/typespec-python": |
There was a problem hiding this comment.
@msyyc could you verify?
There was a problem hiding this comment.
Not sure what is the meaning of normalizePackageName and ServiceNamespace and you can refer to the template https://github.com/Azure/azure-rest-api-specs/blob/ab67c148ec716a0d0075770742d54468f128c72e/specification/contosowidgetmanager/Contoso.Management/tspconfig.yaml#L18-L23
There was a problem hiding this comment.
I copied it from the data plane template:
What do you recommend the generic value for
package-dir should be?
maririos
commented
Dec 11, 2024
| package-dir: "{{#normalizePackageName}}{{parameters.ServiceNamespace}}{{/normalizePackageName}}" | ||
| namespace: com.{{#toLowerCase}}{{parameters.ServiceNamespace}}{{/toLowerCase}} | ||
| service-name: "{service-name}" | ||
| "@azure-tools/typespec-ts": |
There was a problem hiding this comment.
@wanlwanl could you verify? is modular what we recommend for the template?
|
You can try these changes here
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1842
We have been working on updating and reviewing the template for SDK emitters on arm. Adding values here so people get the template when they do
tsp init