Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Dapeng's LRO usage to release #1957

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented Dec 6, 2024

cherry pick from: #1887

…RO (#1887)

Remove this workaround since #311 is closed.
Fixes #1752
Fixes #1530

This PR adds three new usage flags: `LroInitial`, `LroPolling`,
`LroFinalEnvelope`.
These new usage flags are previously represented by `Output`, now the
`Output` flag no longer contain the semantics of these usages.
Therefore, if a model's usage is only `LroInitial`, this means it is
only used as the initial response of an LRO.
if a model has both `LroInitial` and `Output`, this means it is used as
the initial response of an LRO, and it also used as a normal output in
other places.
The final result will not have above new usages unless it participates
as those roles as well. It will have output usage.
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 6, 2024

All changed packages have been documented.

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - feature ✏️

  1. Introduce new usage: LroInitial, LroPolling, LroFinalEnvelope.,> 2. usage and access now properly propagate on polling model, final result and final envelop result of lroMetadata.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@iscai-msft iscai-msft enabled auto-merge (squash) December 6, 2024 19:22
@iscai-msft iscai-msft merged commit e5a853e into release/november-2024 Dec 6, 2024
22 checks passed
@iscai-msft iscai-msft deleted the tcgc/lroUsage branch December 6, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants