[tcgc] refine model output test #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelesh
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar and
joheredi
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
|
All changed packages have been documented.
|
tadelesh
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
weidongxu-microsoft
approved these changes
Dec 5, 2024
|
You can try these changes here
|
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Dec 5, 2024
this pr does not change any tcgc logic, just change the test mechanism for tccg model output. i no longer used raw yaml snapshot to do comparison, instead will load the yaml output and check the critical part. this will help to reduce the frequency to update the raw yaml snapshot because of other package's changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr does not change any tcgc logic, just change the test mechanism for tccg model output. i no longer used raw yaml snapshot to do comparison, instead will load the yaml output and check the critical part. this will help to reduce the frequency to update the raw yaml snapshot because of other package's changes.