Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] support typespec common paging #1919

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Conversation

tadelesh
Copy link
Member

support typespec common paging.

currently, typspec does not support using pageable decorator in nested properties, related test is skipped.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 27, 2024

All changed packages have been documented.

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - feature ✏️

support typespec common paging

@azure-tools/typespec-client-generator-core - fix ✏️

use the right path parameter name when filtering method parameter

@azure-tools/typespec-client-generator-core - feature ✏️

remove none visibility property for model

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There is a bunch of code in the PR, so best to have another reviewer to approve.

@tadelesh
Copy link
Member Author

added test for getPropertyPathFromModel

@tadelesh tadelesh enabled auto-merge (squash) November 28, 2024 07:22
@tadelesh tadelesh merged commit b165473 into release/november-2024 Nov 28, 2024
22 checks passed
@tadelesh tadelesh deleted the common_paging branch November 28, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants