Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Azure.Core.nextLink in favor of TypeSpec.nextLink #1886

Merged
merged 13 commits into from
Dec 7, 2024
Merged

Remove Azure.Core.nextLink in favor of TypeSpec.nextLink #1886

merged 13 commits into from
Dec 7, 2024

Conversation

AlitzelMendez
Copy link
Member

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 19, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/azure-http-specs
  • ✅ @azure-tools/typespec-azure-core
  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-core - fix ✏️

Remove Azure.Core.nextLink as there is a nextLink instance in TypeSpec.nextLink, which is causing an ambiguous problem between the two.

@azure-tools/typespec-azure-resource-manager - fix ✏️

Replace usage of Azure.Core.nextLink to TypeSpec.nextLink.

@azure-tools/azure-http-specs - fix ✏️

Replace usage of Azure.Core.nextLink to TypeSpec.nextLink.

@AlitzelMendez AlitzelMendez marked this pull request as ready for review November 19, 2024 18:04
@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@AlitzelMendez AlitzelMendez marked this pull request as draft November 19, 2024 19:19
@AlitzelMendez AlitzelMendez changed the title Remove Azure.Core.nextLink in favor of TypeSpec.nextLink [WIP] Remove Azure.Core.nextLink in favor of TypeSpec.nextLink Nov 19, 2024
@AlitzelMendez AlitzelMendez changed the title [WIP] Remove Azure.Core.nextLink in favor of TypeSpec.nextLink Remove Azure.Core.nextLink in favor of TypeSpec.nextLink Dec 3, 2024
@AlitzelMendez AlitzelMendez marked this pull request as ready for review December 3, 2024 01:49
@AlitzelMendez AlitzelMendez linked an issue Dec 3, 2024 that may be closed by this pull request
[Bug]: [Ask]Ambiguous-symbol "nextLink" is an ambiguous name between TypeSpec.nextLink, Azure.Core.nextLink microsoft/typespec#5048
Closed
4 tasks
@AlitzelMendez AlitzelMendez mentioned this pull request Dec 3, 2024
Closed
markcowl
markcowl reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: We should try this PR in the azure-rest-api-specs public repo, fix any issues and and link to that PR here

This was referenced Dec 4, 2024
Merged
Merged
@AlitzelMendez
Copy link
Member Author

@markcowl sharing with you the other pull requests related to this change

Related pull requestes

@markcowl markcowl self-assigned this Dec 5, 2024
@Azure Azure deleted a comment from tadelesh Dec 6, 2024
@AlitzelMendez AlitzelMendez added this pull request to the merge queue Dec 7, 2024
Merged via the queue into Azure:main with commit 4630826 Dec 7, 2024
23 checks passed
@AlitzelMendez AlitzelMendez deleted the remove-azure-core-nextlink branch December 7, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees

@markcowl markcowl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [Ask]Ambiguous-symbol "nextLink" is an ambiguous name between TypeSpec.nextLink, Azure.Core.nextLink
4 participants
@AlitzelMendez @azure-sdk @markcowl @iscai-msft