Implement scope negation for TCGC #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live1206
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar and
joheredi
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
live1206
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
XiaofeiCao
reviewed
Nov 1, 2024
packages/typespec-client-generator-core/test/decorators.test.ts
Outdated
Show resolved
Hide resolved
tadelesh
reviewed
Nov 1, 2024
XiaofeiCao
reviewed
Nov 1, 2024
XiaofeiCao
reviewed
Nov 1, 2024
tadelesh
reviewed
Nov 4, 2024
packages/typespec-client-generator-core/test/decorators.test.ts
Outdated
Show resolved
Hide resolved
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
XiaofeiCao
reviewed
Nov 7, 2024
tadelesh
approved these changes
Nov 7, 2024
packages/typespec-client-generator-core/test/decorators.test.ts
Outdated
Show resolved
Hide resolved
packages/typespec-client-generator-core/test/decorators.test.ts
Outdated
Show resolved
Hide resolved
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Dec 5, 2024
Resolves Azure#1596 There are 2 formats of scope negation: ``` @clientName("A", "!(python, java)") Model foo ``` is equivalent to ``` @clientName("A", "!python, !java") Model foo ``` We allow combination of normal scope and negation scope for different scopes ``` @clientName("A", "!python, csharp") Model foo ``` Combination of same scope is also allowed ``` @clientName("A", "!python, python") Model foo ``` is equivalent to ``` @clientName("A", "!python") @clientName("A", "python") Model foo ``` and equivalent to ``` @clientName("A") Model foo ``` The rule for decorator override: - for the same scope, the later decorator value wins regardless it's defined with normal scope or scope negation Detailed override cases can be found in the tests of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1596
There are 2 formats of scope negation:
is equivalent to
We allow combination of normal scope and negation scope for different scopes
Combination of same scope is also allowed
is equivalent to
and equivalent to
The rule for decorator override:
Detailed override cases can be found in the tests of this PR.