Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][TCGC 0.41.4]: @clientName not work #730

Closed
4 tasks done
Tracked by #4300
archerzz opened this issue Apr 24, 2024 · 2 comments · Fixed by #731
Closed
4 tasks done
Tracked by #4300

[Bug][TCGC 0.41.4]: @clientName not work #730

archerzz opened this issue Apr 24, 2024 · 2 comments · Fixed by #731
Assignees
@tadelesh
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library needs-area

Comments

@archerzz
Copy link
Member

Describe the bug

Try a TypeSpec spec including @clientName, like: https://github.com/Azure/azure-rest-api-specs/blob/2897e4040dd3d922061ae55bc002358aeaded619/specification/devcenter/DevCenter/client.tsp#L166

In the generated codes, @clientName is not honored. See this preview gen from csharp: Azure/azure-sdk-for-net#43608

Looks like for some reason, the decorator value is not correctly saved:
image

Reproduction

Just try the above TypeSpec spec.

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@archerzz archerzz added the bug Something isn't working label Apr 24, 2024
@archerzz archerzz mentioned this issue Apr 24, 2024
Closed
@lirenhe lirenhe added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Apr 24, 2024
@lirenhe
Copy link
Member

lirenhe commented Apr 24, 2024

@iscai-msft / @tadelesh , could you help to resolve this with priority? Seems it blocks our codegen to move to the latest version of TCGC.

@tadelesh
Copy link
Member

Regression of versioning support for this issue: #233. I've fixed it.

@tadelesh tadelesh mentioned this issue Apr 24, 2024
Merged
@qiaozha qiaozha mentioned this issue Apr 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 24, 2024
@tadelesh
[tcgc] fix @clientName lost after adding versioning support (#731)
1a4fd0d 
fixes #730

---------

Co-authored-by: iscai-msft <[email protected]>
@tadelesh tadelesh mentioned this issue Apr 28, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadelesh tadelesh

Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library needs-area
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tcgc] fix @clientName lost after adding versioning support Azure/typespec-azure
4 participants
@archerzz @tadelesh @lirenhe @iscai-msft