Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie support in tcgc #1792

Closed
timotheeguerin opened this issue Nov 1, 2024 · 3 comments · Fixed by #1812
Closed

Cookie support in tcgc #1792

timotheeguerin opened this issue Nov 1, 2024 · 3 comments · Fixed by #1812
Assignees
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@timotheeguerin
Copy link
Member

timotheeguerin commented Nov 1, 2024

Basic cookie support was added in TypeSpec http(for request parmater. Right now tcgc will crash if it get cookies, should maybe emit a diagnostic if this is not a goal to support

#1791 uptook the change but as it was a little more advanced to emit the diagnostic filed an issue

@timotheeguerin timotheeguerin added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Nov 1, 2024
@MaryGao
Copy link
Member

MaryGao commented Nov 4, 2024

Our nightly ci failed with the same reason. And I don't think we have general cookie parameter support in azure core or codegen for JS yet. I didn't notice we have a real azure service impacted yet.

@lmazuel @lirenhe what is this our goal to support this? Could we directly emit a diagnostic and just ignore this parameter for now?

op test(@cookie MyCookie: string): string;

@timotheeguerin
Copy link
Member Author

@MaryGao thats just the ts compilation right? It doesn't fail on existing specs?

@MaryGao
Copy link
Member

MaryGao commented Nov 5, 2024

Offline confirmed with @timotheeguerin this is an community contribution for a feature wanted for third party and we don't have a requirement yet for emitter so we could ignore the parameter and emit warning to let customers be aware of that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants