Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve docs for dataplane code generation for Discriminator support #1349

Closed
Tracked by #245
lirenhe opened this issue Aug 12, 2024 · 0 comments · Fixed by #1676
Closed
Tracked by #245

[docs] Improve docs for dataplane code generation for Discriminator support #1349

lirenhe opened this issue Aug 12, 2024 · 0 comments · Fixed by #1676
Assignees
@ArcturusZhang
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@lirenhe
Copy link
Member

lirenhe commented Aug 12, 2024 •
edited
Loading

Each language has it unique design for discriminator support, we need to document the codegen behavior to avoid confusion.
@lirenhe lirenhe mentioned this issue Aug 12, 2024
Open
@lirenhe lirenhe added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Aug 12, 2024
@lirenhe lirenhe changed the title Discriminator [docs] Improve docs for dataplane code generation for Discriminator support Aug 12, 2024
@ArcturusZhang ArcturusZhang mentioned this issue Oct 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2024
@ArcturusZhang @weidongxu-microsoft
@tadelesh @MaryGao
add docs for discriminator (#1676)
87c1c48 
Fixes #1349

---------

Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: tadelesh <[email protected]>
Co-authored-by: Mary Gao <[email protected]>
markcowl pushed a commit to markcowl/typespec-azure that referenced this issue Dec 5, 2024
@ArcturusZhang @weidongxu-microsoft
@tadelesh @MaryGao @markcowl
add docs for discriminator (Azure#1676)
c5214d6 
Fixes Azure#1349

---------

Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: tadelesh <[email protected]>
Co-authored-by: Mary Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArcturusZhang ArcturusZhang

Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add docs for discriminator ArcturusZhang/typespec-azure
2 participants
@lirenhe @ArcturusZhang