Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][TCGC] TCGC shall not ignore content-type in output property headers #1112

Closed
msyyc opened this issue Jul 2, 2024 · 0 comments · Fixed by #1113
Closed

[Bug][TCGC] TCGC shall not ignore content-type in output property headers #1112

msyyc opened this issue Jul 2, 2024 · 0 comments · Fixed by #1113
Assignees
@msyyc
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@msyyc
Copy link
Member

msyyc commented Jul 2, 2024

For the following Typespec:
https://github.com/Azure/azure-rest-api-specs/blob/87a08b955c257c773a3bd42553c718d4b1092955/specification/schemaregistry/SchemaRegistry/main.tsp#L234-L238, TCGC doesn't output header content-type. The root cause is: after refactor, content-type is moved as special body property instead of headers. TCGC also needs special logic to extract content type to headers again.
@msyyc msyyc self-assigned this Jul 2, 2024
@msyyc msyyc added lib:tcgc Issues for @azure-tools/typespec-client-generator-core library and removed needs-area labels Jul 2, 2024
@msyyc msyyc changed the title [Bug][TCGC] ignore content-type defined in response [Bug][TCGC] TCGC shall not ignore content-type defined in response in output property headers Jul 2, 2024
@msyyc msyyc changed the title [Bug][TCGC] TCGC shall not ignore content-type defined in response in output property headers [Bug][TCGC] TCGC shall not ignore content-type in output property headers Jul 2, 2024
This was referenced Jul 2, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@msyyc
[Tcgc] add content-type in response headers (#1113)
a7a5101 
fixes #1112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msyyc msyyc

Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tcgc] add content-type in response headers Azure/typespec-azure
1 participant
@msyyc