Skip to content

Commit

Permalink
Set failTaskOnFailedTests=false in CI pipeline (#426)
Browse files Browse the repository at this point in the history
The task running tests already fails if tests have failed:


![image](https://github.com/Azure/typespec-azure/assets/351644/179f7f33-1e77-46cc-b49a-f7705d839e88)

So the task publishing the test results failing makes a wrong impression
that it failed to upload the test results, what's not the case.
  • Loading branch information
abatishchev authored Mar 14, 2024
1 parent ac16317 commit e42c90e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions eng/pipelines/jobs/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ steps:
searchFolder: "$(System.DefaultWorkingDirectory)/core/packages"
testResultsFiles: "*/test-results.xml"
mergeTestResults: true
failTaskOnFailedTests: true
failTaskOnFailedTests: false
testRunTitle: "[CORE] Test os: ${{ parameters.poolName }}, node: ${{ parameters.nodeVersion }}"
displayName: Publish core test results
condition: always()
Expand All @@ -72,7 +72,7 @@ steps:
searchFolder: "$(System.DefaultWorkingDirectory)/packages"
testResultsFiles: "*/test-results.xml"
mergeTestResults: true
failTaskOnFailedTests: true
failTaskOnFailedTests: false
testRunTitle: "[NON-CORE] Test os: ${{ parameters.poolName }}, node: ${{ parameters.nodeVersion }}"
displayName: Publish non-core test results
condition: always()
Expand Down

0 comments on commit e42c90e

Please sign in to comment.