Skip to content

Commit

Permalink
[tcgc] keep tcgc experimental (#576)
Browse files Browse the repository at this point in the history
  • Loading branch information
iscai-msft authored Apr 2, 2024
1 parent 1560003 commit 70186b9
Show file tree
Hide file tree
Showing 7 changed files with 199 additions and 199 deletions.
7 changes: 0 additions & 7 deletions .chronus/changes/add_sdk_package-2024-3-1-11-37-51.md

This file was deleted.

7 changes: 7 additions & 0 deletions .chronus/changes/make_experimental-2024-3-2-12-29-51.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: internal
packages:
- "@azure-tools/typespec-client-generator-core"
---

make sdkPackage experimental again
5 changes: 1 addition & 4 deletions packages/typespec-client-generator-core/src/decorators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -512,17 +512,14 @@ export function createSdkContext<
program: context.program,
emitContext: context,
experimental_sdkPackage: undefined!,
sdkPackage: undefined!,
emitterName: parseEmitterName(emitterName ?? context.program.emitters[0]?.metadata?.name), // eslint-disable-line deprecation/deprecation
generateProtocolMethods: generateProtocolMethods,
generateConvenienceMethods: generateConvenienceMethods,
filterOutCoreModels: context.options["filter-out-core-models"] ?? true,
packageName: context.options["package-name"],
flattenUnionAsEnum: context.options["flatten-union-as-enum"] ?? true,
};
sdkContext.sdkPackage = getSdkPackage(sdkContext);
// eslint-disable-next-line deprecation/deprecation
sdkContext.experimental_sdkPackage = sdkContext.sdkPackage;
sdkContext.experimental_sdkPackage = getSdkPackage(sdkContext);
return sdkContext;
}

Expand Down
4 changes: 0 additions & 4 deletions packages/typespec-client-generator-core/src/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,7 @@ export interface SdkContext<
TServiceOperation extends SdkServiceOperation = SdkHttpOperation,
> extends TCGCContext {
emitContext: EmitContext<TOptions>;
/**
* @deprecated This property is deprecated. Use `.sdkPackage` instead.
*/
experimental_sdkPackage: SdkPackage<TServiceOperation>;
sdkPackage: SdkPackage<TServiceOperation>;
__clients?: SdkClientType<TServiceOperation>[];
}

Expand Down
Loading

0 comments on commit 70186b9

Please sign in to comment.