[tcgc] add .sdkPackage now that the design is finalized (#562)

.chronus/changes/add_sdk_package-2024-3-1-11-37-51.md

@@ -0,0 +1,7 @@
+---
+changeKind: deprecation
+packages:
+  - "@azure-tools/typespec-client-generator-core"
+---
+
+deprecate `SdkContext.experimetal_sdkPackage` and add `SdkContext.sdkPackage` now that the design for `sdkPackage` is set

packages/typespec-client-generator-core/src/decorators.ts

@@ -39,7 +39,7 @@ import {
 } from "./interfaces.js";
 import { TCGCContext, parseEmitterName } from "./internal-utils.js";
 import { createStateSymbol, reportDiagnostic } from "./lib.js";
-import { experimental_getSdkPackage } from "./package.js";
+import { getSdkPackage } from "./package.js";
 import { getLibraryName } from "./public-utils.js";
 import { getSdkEnum, getSdkModel, getSdkUnion } from "./types.js";
 
@@ -512,14 +512,17 @@ export function createSdkContext<
     program: context.program,
     emitContext: context,
     experimental_sdkPackage: undefined!,
+    sdkPackage: undefined!,
     emitterName: parseEmitterName(emitterName ?? context.program.emitters[0]?.metadata?.name), // eslint-disable-line deprecation/deprecation
     generateProtocolMethods: generateProtocolMethods,
     generateConvenienceMethods: generateConvenienceMethods,
     filterOutCoreModels: context.options["filter-out-core-models"] ?? true,
     packageName: context.options["package-name"],
     flattenUnionAsEnum: context.options["flatten-union-as-enum"] ?? true,
   };
-  sdkContext.experimental_sdkPackage = experimental_getSdkPackage(sdkContext);
+  sdkContext.sdkPackage = getSdkPackage(sdkContext);
+  // eslint-disable-next-line deprecation/deprecation
+  sdkContext.experimental_sdkPackage = sdkContext.sdkPackage;
   return sdkContext;
 }
 

packages/typespec-client-generator-core/src/interfaces.ts

@@ -25,7 +25,11 @@ export interface SdkContext<
   TServiceOperation extends SdkServiceOperation = SdkHttpOperation,
 > extends TCGCContext {
   emitContext: EmitContext<TOptions>;
+  /**
+   * @deprecated This property is deprecated. Use `.sdkPackage` instead.
+   */
   experimental_sdkPackage: SdkPackage<TServiceOperation>;
+  sdkPackage: SdkPackage<TServiceOperation>;
   __clients?: SdkClientType<TServiceOperation>[];
 }
 

packages/typespec-client-generator-core/src/package.ts

@@ -530,7 +530,7 @@ function createSdkClientType<
   return diagnostics.wrap(sdkClientType);
 }
 
-export function experimental_getSdkPackage<
+export function getSdkPackage<
   TOptions extends object,
   TServiceOperation extends SdkServiceOperation,
 >(context: SdkContext<TOptions, TServiceOperation>): SdkPackage<TServiceOperation> {