Tried to align TF HCL files with their generated versions #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added [documented](https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules#microsoftsynapse) `synapse_workspace` restrictions to _resourceDefinitions.json_. - `make all`.
|
|
|
This would be a breaking change need to verify it better thanks for the contribution |
Nepomuceno
approved these changes
May 27, 2023
Nepomuceno
approved these changes
Nov 13, 2023
|
THere is a conflict are you willing to update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks as though the main.tf and output.tf have drifted a bit from their generated versions, specifically with #40 and #53. Tried to reconcile these differences:
synapse_workspacerestrictions to resourceDefinitions.json.make all.Note that dashes are now allowed in
synapse_workspace.