Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] Add validation block to enforce users to change sku_tier from Paid to Standard. #346

Merged
merged 1 commit into from
Apr 11, 2023
Merged

[Breaking] Add validation block to enforce users to change sku_tier from Paid to Standard. #346

merged 1 commit into from
Apr 11, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

Issue number

#345

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb changed the title Add validation block to enforce users to change sku_tier from Paid to Standard. [Breaking] Add validation block to enforce users to change sku_tier from Paid to Standard. Apr 10, 2023
@lonegunmanb lonegunmanb added this to the 7.0.0 milestone Apr 10, 2023
@lonegunmanb lonegunmanb temporarily deployed to acctests April 10, 2023 04:22 — with GitHub Actions Inactive
jiaweitao001
jiaweitao001 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@lonegunmanb lonegunmanb merged commit a0747e2 into Azure:main Apr 11, 2023
@lonegunmanb lonegunmanb deleted the f-345 branch November 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @jiaweitao001