-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to setup multiple node pools #212
Conversation
Thanks @Sanverik for opening this PR! My personal opinion this module will focus on Aks cluster itself. The caller might attach multiple node pools with different configurations to one Aks cluster so I prefer a standalone module for the node pool. |
@lonegunmanb @Sanverik what about transform this PR using a submodule of the AKS module ? |
@nlamirault I don't see any reason to create additional module for a wrapper around one resource (like AKS module already is) |
For me it looks natural to have an option to specify multiple node pool within AKS module by using my way of doing it |
MAIN BRANCH PUSH DETECTED DUE TO #241, THIS PR WILL BE UPDATED. |
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
MAIN BRANCH PUSH DETECTED DUE TO #230, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
1 similar comment
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
MAIN BRANCH PUSH DETECTED DUE TO #253, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
MAIN BRANCH PUSH DETECTED DUE TO #249, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
MAIN BRANCH PUSH DETECTED DUE TO #245, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
@Sanverik Thanks for opening this pr, I'm closing it because I'd like to keep this module focused on Kubernetes cluster itself. |
Changes proposed in the pull request: