feat(chart): add proxy config override template #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a template for proxy-config Secret which is meant
to replace the proxy-config secret in the osm subchart. Because
the default value of .Values.fluentBit.enableProxySupport in the
osm subchart is false AND we do not change this value as part of the
parent chart, we can create a new proxy-config Secret in the parent
chart if the azureHTTPProxy and azureHTTPSProxy values are passed in
at install time.
To test these changes, run:
$ helm template charts/osm-arc > output1.yaml
In output1.yaml, you should not find a Secret called proxy-config. Neither chart created a Secret called proxy-config.
To see the proxy-config Secret, run:
$ helm template charts/osm-arc --set "azureHTTPProxy=something1,azureHTTPSProxy=something2" > output2.yaml
In output2.yaml, you should see a Secret called proxy-config. This was created by the parent chart because the two values related to proxy settings were passed in.
Note: these are not the final value names. Once those are finalized by the azure arc extension team, we can update them and the configuration in this chart.
Signed-off-by: Michelle Noorali [email protected]