Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): add proxy config override template #48

Closed
wants to merge 1 commit into from

Conversation

michelleN
Copy link
Contributor

@michelleN michelleN commented Jan 14, 2021

This adds a template for proxy-config Secret which is meant
to replace the proxy-config secret in the osm subchart. Because
the default value of .Values.fluentBit.enableProxySupport in the
osm subchart is false AND we do not change this value as part of the
parent chart, we can create a new proxy-config Secret in the parent
chart if the azureHTTPProxy and azureHTTPSProxy values are passed in
at install time.

To test these changes, run:
$ helm template charts/osm-arc > output1.yaml
In output1.yaml, you should not find a Secret called proxy-config. Neither chart created a Secret called proxy-config.

To see the proxy-config Secret, run:
$ helm template charts/osm-arc --set "azureHTTPProxy=something1,azureHTTPSProxy=something2" > output2.yaml
In output2.yaml, you should see a Secret called proxy-config. This was created by the parent chart because the two values related to proxy settings were passed in.

Note: these are not the final value names. Once those are finalized by the azure arc extension team, we can update them and the configuration in this chart.

Signed-off-by: Michelle Noorali [email protected]

This adds a template for proxy-config Secret which is meant
to replace the proxy-config secret in the osm subchart. Because
the default value of .Values.fluentBit.enableProxySupport in the
osm subchart is false AND we do not change this value as part of the
parent chart, we can create a new proxy-config Secret in the parent
chart if the azureHTTPProxy and azureHTTPSProxy values are passed in
at install time.

Signed-off-by: Michelle Noorali <[email protected]>
@michelleN
Copy link
Contributor Author

/azp run pr-e2e-arc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@michelleN
Copy link
Contributor Author

will add some tests for this

@michelleN
Copy link
Contributor Author

From the proxy email thread, the values we need to expose should look like this:

Azure:

  proxySettings:

    isProxyEnabled: true/false

    httpProxy: ""

    httpsProxy: ""

    noProxy: ""

    proxyCert: ""

@michelleN
Copy link
Contributor Author

@michelleN
Copy link
Contributor Author

Closing in favor of #54

@michelleN michelleN closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant