Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump,ci,fix: bump up dependencies and enable AOT #156

Merged
merged 15 commits into from
Apr 3, 2024
Merged

bump,ci,fix: bump up dependencies and enable AOT #156

merged 15 commits into from
Apr 3, 2024

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented Mar 27, 2024 •
edited
Loading

Bump (required for AOT):

  • Azure.Security.KeyVault.Certificates v4.6.0
  • Azure.Security.KeyVault.Keys v4.6.0
  • Azure.Security.KeyVault.Secrets v4.6.0

CI:

  • enable AOT for linux-x64, linux-arm64, win-x64
  • the binary size reduced from 64MiB+ to about 14 MiB
  • updated test.yaml and release.yaml pipeline
  • deprecated build.sh and replaced with build.py for cross platform support

Fix:

  • added Visual Studio Solution File

Test:

@JeyJeyGao JeyJeyGao requested a review from shizhMSFT March 27, 2024 08:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (1d44efe) to head (5decc02).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files          16       16           
  Lines         581      581           
  Branches       72       72           
=======================================
  Hits          530      530           
  Misses         38       38           
  Partials       13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
fix: update build script
4a9f916 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update code
90ff2ca 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update relase pipeline
352d203 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao changed the title fix&bump: bump up dependencies and enable AOT ci&bump: bump up dependencies and enable AOT Mar 29, 2024
@JeyJeyGao
fix: add ARM emulator for AOT build
debb0ef 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update release
a6b5fdc 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update release
6cf497f 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update relase
ae5430c 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update release
f9df294 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update build script
51bc2ab 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update relase
385ed8d 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update release
6544e46 
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
JeyJeyGao commented Mar 29, 2024
View reviewed changes
scripts/build.py
tar.add(os.path.join(binary_dir, binary_name), arcname=binary_name)
tar.add("LICENSE")


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple empty lines are intentional in the Python script.

@JeyJeyGao JeyJeyGao changed the title ci&bump: bump up dependencies and enable AOT bump,ci,fix: bump up dependencies and enable AOT Mar 29, 2024
shizhMSFT
shizhMSFT approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

.github/workflows/release.yml Outdated Show resolved Hide resolved
scripts/build.py Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT requested a review from Two-Hearts April 2, 2024 11:55
Two-Hearts
Two-Hearts approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 8f95641 into main Apr 3, 2024
10 checks passed
@JeyJeyGao JeyJeyGao deleted the junjie/fix/reduce_size branch April 3, 2024 06:41
@JeyJeyGao JeyJeyGao mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeyJeyGao @codecov-commenter @shizhMSFT @Two-Hearts