Implement authentication for usernames/passwords using adal #3
Conversation
| def __init__(self, username, password, **kwargs): | ||
| super(AdalUserPassCredentials, self).__init__(**kwargs) | ||
| self.username = username | ||
| self.password = password |
There was a problem hiding this comment.
This implies that credentials are not tested at the instance creation, but at the instance usage. This is different from current UserPassCredentials behavior.
I think we might want to keep the current behavior, but I'm open to discussion (@annatisch)
|
|
||
| """Base class for adal-derived authentication.""" | ||
|
|
||
| def __init__(self, client_id="04b07795-8ddb-461a-bbee-02f9e1bf7b46", |
There was a problem hiding this comment.
I'd prefer to have this id in a constant XPLAT_APP_ID since it's not recommend anymore to use it:
https://github.com/AzureAD/azure-activedirectory-library-for-python#about-client_id-and-resource-arguments
|
Hi @brettcannon, @lmazuel The changes look good. In order to integrate the refresh token functionality we would need to use an oauth-requestslib Session as opposed to a standard requests Session. Alternatively, maybe ADAL has refresh token handling built in - and we can access it be doing a token acquisition at the time of creating the Session? I'm not sure - I'll take a look at ADAL. |
|
Close since integrated in #8 |
|
Nope, closing was the right thing to do. |
No description provided.