-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create terraform backends from the UI #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nlz into glennmusa/setuptfstateforui
…nlz into glennmusa/setuptfstateforui
glennmusa
requested review from
Breanna-Stryker,
brooke-hamilton and
Phydeauxman
April 5, 2021 21:56
glennmusa
changed the title
Create terraform backends from the UI
create terraform backends from the UI
Apr 5, 2021
6 tasks
Breanna-Stryker
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome refactor, this looks great and is far more maintainable.
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update changes how the front-end creates the required resources to deploy the MLZ Configuration Resources (the Service Principal and KeyVault(s)) and terraform backend resources (storage accounts and containers. KeyVaults, contributor roles).
To give this a shot, login to a commercial cloud using the AZ CLI and try:
src/scripts/setup_ezdeploy.sh -s {sub_id}
The high points are:
updates setup_ezdeploy.sh to use many more defaults and deploy an operational front-end with just:
./setup_ezdeploy.sh -s {sub_id}
refactors setup_ezdeploy.sh to call multiple files
scripts/setup_ezdeploy_local.sh
if the docker strategylocal
is specifiedscripts/container-registry/create_acr.sh
to create new Azure Container Registry instances from an mlz_tf_cfg.varscripts/container-registry/deploy_instance.sh
to deploy a container into the new ACRscripts/container-registry/add_auth_scopes.sh
to add User.Read permissions for the container in the ACRintroduces
scripts/config/generate_config_file.sh
as a way to consistently create new mlz_tf_cfg.var files to drive deployments from the shell or UI and allows for setting defaults (like, say, a user doesn't specify a T0 subscription id, it will default to the configuration subscription ID)updates the front end to use defaults for user-supplied values for Hub through Tier 2
introduces a new means of gathering user input instead of
get_opts
:adds
checkfordocker.sh
to check for tooling requirementsIssue reference
The issue this PR will close: #140
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck
.vscode/extensions.json
.)