Use creds
as supplementary of individual parameters
#328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is going to read
creds
from Json, the items increds
will not overwrite the individual parametersclient-id
,tenant-id
andsubscription-id
, but as supplementary.In the previous code,
creds
is not compatible with individual parameters. We usecreds
for login using service principal with secret and individual parameters forOIDC
login:login/src/main.ts
Lines 78 to 93 in 990b22f
In the new version, we aim to fetch the user's input credentials as much as possible:
login/src/common/LoginConfig.ts
Lines 35 to 42 in b3bc91b
We remove the boolean
enableOIDC
and useservicePrincipalKey
to decide whether OIDC is enabled.We also remove the adjudication for undefined
federatedToken
in L122, since the error will be caught in L118. (Related to Support OIDC for sovereign clouds #321)login/src/main.ts
Lines 115 to 129 in 990b22f