-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure/login pre step takes up to 1 minute to execute #456
Comments
Pending fix of Azure#456
Pending fix of Azure#456
commit c9795fb Author: Damian Hickey <[email protected]> Date: Wed Aug 14 12:18:53 2024 +0200 Disable pre and post steps Pending fix of Azure#456
Hi @olafurnielsen and @damianh, we've released a new version v2.2.0. In this version, we removed the Just FYI, the time cost is mainly for login context initialization. After we remove |
Hi @YanaXu I've been trying the mentioned version, with both AZURE_LOGIN_PRE_CLEANUP and AZURE_LOGIN_POST_CLEANUP set to false and i'm having an average of 1 minute for the login action. EDIT: Can we use a composite action to cache the login so it doesn't have to be redone every time? |
Hi @GoncaloPT , could you help me check these questions?
The login time cost depends on underlying Azure CLI and Azure PowerShell. They needs time to init the login context. |
Hi @YanaXu, thanks for your reply. Replying to your questions:
Regarding the time cost you present, I haven't been able to reproduce logins near those ones values.. The full roundtrip of login + fetch one secret from key vault took from 1m:13s up to 1:50s. |
Any news here? I’m experiencing timings in the ballpark of 30-45 seconds at times when using this action on GitHub-hosted runners. Surely something as simple (I know it’s not actually that simple, but still) shouldn’t take more than 5 seconds. |
Observed behavior:
The pre step in azure/login takes up to 1 minute to execute. Very seldom does it take a few seconds to execute. In some of our builds this accounts for half the total build time.
Expected behavior:
The step should consistently execute in a few seconds.
Information:
azure/login@v2
Used as:
Resulting in:
What can be done to speed this up?
The text was updated successfully, but these errors were encountered: