Add PoP token support to interactive+spn get-token/convert-kubeconfig flows #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When true, flag allows a PoP token to be passed (https://learn.microsoft.com/en-us/entra/msal/dotnet/advanced/proof-of-possession-tokens) instead of a regular bearer token - Flag is false by default (when not provided), i.e. the default flow is still to request a regular bearer token
- Adds a dependency on microsoft authentication library for go - Specifically uses the branch that adds PoP token support
- Use go-cmp to compare Options struct equality in unit test - Fix comment formatting to remove lint errors
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 60.68% 66.66% +5.97%
==========================================
Files 16 22 +6
Lines 1249 1629 +380
==========================================
+ Hits 758 1086 +328
- Misses 445 485 +40
- Partials 46 58 +12
|
3 tasks
Add support for providing --pop-enabled and --pop-claims flags during kubelogin convert-kubeconfig. These flags are only set if login mode is set to interactive, otherwise the flags are ignored.
weinong
reviewed
Aug 30, 2023
weinong
reviewed
Aug 30, 2023
weinong
reviewed
Aug 30, 2023
pkg/token/testdata/ServicePrincipalPoPTokenFromBadPoPClaimsVCR.yaml
Outdated
Show resolved
Hide resolved
rharpavat
changed the title
julienstroheker
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for getting a Proof-of-Possession (PoP) token when running
kubelogin get-tokenwith--login interactivemode.Adds 2 new flags to
kubelogin get-tokenandkubelogin convert-kubeconfig:--pop-enabled: boolean flag indicating whether or not to request a PoP token--pop-claims: string slice formatted as a comma-separated list of key/value pairs, eg."u=host,key2=val2"Both flags must be provided together in order to use the PoP token flow; providing one but not the other will result in an error during flag validation. PoP claims must contain the
uclaim containing the ARM ID of the cluster (host) to request the PoP token for, in the format"u=<ARM_ID>".