Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make installation of VC runtime optional on Windows installer #565

Closed
sebader opened this issue Nov 26, 2018 · 2 comments
Closed

Make installation of VC runtime optional on Windows installer #565

sebader opened this issue Nov 26, 2018 · 2 comments
Labels
customer-reported iotedge

Comments

@sebader
Copy link
Member

sebader commented Nov 26, 2018

The powershell install script for Windows supports now to supply a previously downloaded zip file ("archive") of the IoT Edge daemon. But it will still try to download and install every the VC runtime.
It should be either

  • made optional to download and install VC at all
  • or at least, give the user the chance to manually supply the path to the downloaded installer.exe similar to the IoT Edge daemon.

Especially when re-installing Edge, the VC is obviously already there and downloading it again just takes unnecessary time. Or - even worse - in cases where the device does not have internet connectivity, even behind a proxy, this might fail.

Still seems the case in the latest PR regarding the installer: https://github.com/Azure/iotedge/pull/550/files#diff-8ae7a24c87a2048c653a1cfb9f7e1d8bR502
@myagley
Copy link
Contributor

myagley commented Nov 28, 2018

Thanks for the feedback. We will look at getting the installation script updated.

@sebader
Copy link
Member Author

sebader commented Nov 28, 2018

This is also needed for the newly added Moby-binaries. We need to have an installer, that is fully offline-capable. In many cases the Edge device will have no general internet connectivity at all.

@myagley myagley mentioned this issue Nov 30, 2018
Merged
arsing added a commit that referenced this issue Dec 3, 2018
@arsing
More Windows installer changes (#592)
8cec3d5 
- Add new `-InvokeWebRequestParameters` parameter. This can be used to specify
  extra options for all `Invoke-WebRequest` calls, like `-Proxy` and
  `-ProxyCredentials`. The `-Proxy` parameter to the installer function itself
  is left for backward-compatibility.

- Add new `-OfflineInstallationPath` parameter for offline installs.
  This should be set to a directory that contains one or more files.
  For each component that the installer downloads (iotedged, Moby Engine,
  Moby CLI, VC Runtime), it first checks if the corresponding file is already
  present in this directory. If the file is there, it uses that instead of
  downloading from the internet.

- Change Moby CLI from opt-in to opt-out. `-WithMobyCli` is renamed to
  `-SkipMobyCli`

- Disable iotedge service before stopping it. If the service crashes while
  being stopped, Windows restarts it instead of leaving it stopped.

- Skip VC Runtime installation if `system32\vcruntime140.dll` exists.

- Change all references to "Moby Runtime" to "Moby Engine", except for the
  key in `config.yaml`

Fixes #565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer-reported iotedge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@myagley @sebader @yophilav