Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Content-Length header to XML preparer #567

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Add Content-Length header to XML preparer #567

merged 4 commits into from
Oct 7, 2020

Conversation

mbfrahry
Copy link
Contributor

The Content-Length header is missing from the XML preparer which causes mismatch issues:

The MAC signature found in the HTTP request 'encodedauthorizationtoken' is not the same as any computed signature

This PR adds that in and we don't see the above error message anymore.

jhendrixMSFT
jhendrixMSFT requested changes Oct 2, 2020
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the affected tests?

@mbfrahry
Copy link
Contributor Author

mbfrahry commented Oct 7, 2020

@jhendrixMSFT the test failures have been fixed

@jhendrixMSFT jhendrixMSFT merged commit bf140ad into Azure:master Oct 7, 2020
@stuartleeks stuartleeks mentioned this pull request Oct 9, 2020
Closed
@stuartleeks stuartleeks mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbfrahry @jhendrixMSFT