[for private package] Fail fast on control queue stuck for over 10 minutes #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: Azure/azure-functions-durable-extension#2534
In the issue linked above, we saw a worker using the DTFx.Azure Storage taking over 10 hours to release ownership over a queue it had stopped listening to. Since then, the user has changed to utilizing the Netherite backend, where they seem to be experiencing other issues.
This PR, not to be merged, is to discuss a private mitigation where, if a control queue that we have stopped listening to does not have it's ownership released in over 10 minutes, then we fail fast. Obviously, this is a rather aggressive strategy, so this is not a long term solution nor one we should incorporate in the official release as-is.