Azure Service Fabric based new provider implementation. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Integration Tests. * Integrate with DTFx controllers.
Create Register method.
Listen for `ClientDisconnected` event. Merge both the event sources into single one.
…ithout local caching.
Refactor Event Source.
#2) * Introduce new interface `IServiceListener` to represent each listener in StatefulService. This allows us to develop each listener separately. Migrate current codebase to consume the same.
simonporter
reviewed
Jul 19, 2019
src/DurableTask.AzureServiceFabric/DurableTask.AzureServiceFabric.csproj
Outdated
Show resolved
Hide resolved
simonporter
reviewed
Jul 19, 2019
src/DurableTask.AzureServiceFabric/DurableTask.AzureServiceFabric.csproj
Show resolved
Hide resolved
simonporter
reviewed
Jul 19, 2019
src/DurableTask.AzureServiceFabric/FabricOrchestrationInstanceStore.cs
Outdated
Show resolved
Hide resolved
simonporter
reviewed
Jul 19, 2019
| }, initialDelay: TimeSpan.FromMinutes(5), delayOnSuccess: TimeSpan.FromHours(12), delayOnException: TimeSpan.FromHours(1), actionName: $"{nameof(CleanupDayOldDictionaries)}", token: this.cancellationToken); | ||
| } | ||
|
|
||
| Task CleanupOldDictionaries() |
There was a problem hiding this comment.
CleanupOldDictionaries [](start = 13, length = 22)
Async
simonporter
reviewed
Jul 19, 2019
src/DurableTask.AzureServiceFabric/FabricOrchestrationInstanceStore.cs
Outdated
Show resolved
Hide resolved
simonporter
reviewed
Jul 22, 2019
| /// <summary> | ||
| /// Traces application exceptions. | ||
| /// </summary> | ||
| public class ProxyServiceExceptionsLogger : ExceptionLogger |
There was a problem hiding this comment.
Exceptions [](start = 29, length = 10)
Here and a few other places, use singular in classnames not plural. Also SessionMessagesProvider, SessionsProvider.
simonporter
reviewed
Jul 22, 2019
| public class DefaultStringPartitionHashing : IPartitionHashing<string> | ||
| { | ||
| /// <inheritdoc/> | ||
| public Task<long> GeneratePartitionHashCode(string value, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Task [](start = 15, length = 4)
Interested why a hashing func would return a task. If this should be like this naming should have async suffix
Update version. Address comments.
shankarsama
pushed a commit
to shankarsama/durabletask
that referenced
this pull request
Apr 27, 2021
* * Add DurableTask.ServiceFabric project. * Add Integration Tests. * Integrate with DTFx controllers. * Fixes: 1. Provide ability to store last N execution ids. 2. Provide ability to retun history (with the last event). 3. Fix Generic parameters for the stores. 4. Address code review comments. 5. Implement FabricService. * Provider IHasher interface to abstract hashing strategy. Create Register method. * Addressing code review comments. Listen for `ClientDisconnected` event. Merge both the event sources into single one. * Fix reported issue. * Address code review comments - Implement simple partition resolver, without local caching. * Fix duplicate orchestration issue. Refactor Event Source. * Introduce new interface `IServiceListener` to represent each listener… (Azure#2) * Introduce new interface `IServiceListener` to represent each listener in StatefulService. This allows us to develop each listener separately. Migrate current codebase to consume the same. * Remove IOrchestrationsProvider interface. * Rename to AzureServiceFabric - Folders, CsProj files. * Rename Namespaces. * Add list of contributors. Update version. Address comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will introduce new provider based on Azure Service Fabric.
For more detailed notes refer to src\DurableTask.AzureServiceFabric\ReadMe.md