Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL support #1131

Merged
merged 21 commits into from
Jul 25, 2024
Merged

Add CodeQL support #1131

merged 21 commits into from
Jul 25, 2024

Conversation

davidmrdavid
Copy link
Collaborator

@davidmrdavid davidmrdavid commented Jul 11, 2024

CodeQL (Code Query Language?) is a service that checks against CVEs and other compliance requirements using static analysis in our repos. It needs to be executed weekly.

Our 1ES pipeline already has this, but we need to make it run weekly, so our 1ES pipeline now has a weekly schedule.
We also need to add it directly on GitHub, which is done through the codeQL.yml GitHub workflow.

In addition, our open telemetry sample was throwing a warning because there was an async method nor await'ing anything. I've made the method synchronous to make the warning go away. See: 8d2223a

@davidmrdavid davidmrdavid changed the title [WIP] Add codeQL checks Add CodeQL checks Jul 11, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@davidmrdavid davidmrdavid changed the title Add CodeQL checks Add GitHub Actions improvements: codeql, workflow-dispatch, reduce warnings Jul 11, 2024
@davidmrdavid davidmrdavid changed the title Add GitHub Actions improvements: codeql, workflow-dispatch, reduce warnings Add GitHub Actions improvements: codeql, workflow-dispatch, etc. Jul 11, 2024
@davidmrdavid davidmrdavid changed the title Add GitHub Actions improvements: codeql, workflow-dispatch, etc. [WIP] Add GitHub Actions improvements: codeql, workflow-dispatch, etc. Jul 11, 2024
@davidmrdavid davidmrdavid marked this pull request as draft July 11, 2024 20:57
@davidmrdavid davidmrdavid changed the title [WIP] Add GitHub Actions improvements: codeql, workflow-dispatch, etc. Add CodeQL support Jul 24, 2024
@davidmrdavid davidmrdavid marked this pull request as ready for review July 24, 2024 15:56
@davidmrdavid davidmrdavid marked this pull request as draft July 24, 2024 16:18
@davidmrdavid davidmrdavid marked this pull request as ready for review July 24, 2024 19:19
@davidmrdavid davidmrdavid merged commit 4f82f62 into main Jul 25, 2024
4 checks passed
@cgillum cgillum deleted the dajusto/code-ql branch July 25, 2024 22:15

on:
push:
branches: [ "main", "dajusto/code-ql", "*" ] # TODO: remove development branch after approval
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidmrdavid do the development branches still need to be removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll remove this in a follow up PR, totally blanked out, my mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants