Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft info command #159

Merged
merged 35 commits into from
Nov 10, 2022
Merged

Conversation

davidgamero
Copy link
Collaborator

Description

add the draft info command to print machine-readable summaries of supported languages and deployment types

Feature #157

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Adding an integration test that validates the json output of the info command

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@davidgamero davidgamero changed the title Davidgamero/draft info command draft info command Nov 3, 2022
@davidgamero davidgamero marked this pull request as ready for review November 4, 2022 21:01
Copy link
Collaborator

@sabbour sabbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can we attach example command output? Can we also update the README?

bfoley13
bfoley13 previously approved these changes Nov 9, 2022
@qpetraroia
Copy link
Collaborator

Looks good! Approving ╰(°▽°)╯

qpetraroia
qpetraroia previously approved these changes Nov 9, 2022
@davidgamero davidgamero dismissed stale reviews from qpetraroia and bfoley13 via 4b8cf30 November 9, 2022 22:54
@davidgamero davidgamero merged commit d9d74e7 into Azure:main Nov 10, 2022
@davidgamero davidgamero deleted the davidgamero/draft-info-command branch April 18, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants