Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key-Vault: use now GA'd RBAC permissions instead of Access Policies #22

Closed
julie-ng opened this issue Jun 9, 2021 · 1 comment
Closed

Key-Vault: use now GA'd RBAC permissions instead of Access Policies #22

julie-ng opened this issue Jun 9, 2021 · 1 comment
Assignees
@julie-ng
Labels
terraform

Comments

@julie-ng
Copy link
Collaborator

julie-ng commented Jun 9, 2021

Current implementation uses Key Vault Access Policies

Since this project was initially developed, RBAC for Key Vault has GA'd and we should use that instead for a more unified permissions model across Azure resources.
@julie-ng julie-ng self-assigned this Jun 11, 2021
julie-ng added a commit that referenced this issue Jun 11, 2021
@julie-ng
feat(terraform): simplify for single plan and deploy, #22
c2d3d95 
- key-vault: use RBAC authZ, which has since GA'd
- service connections are set directly from terraform
  instead of indirectly via key vault because:
  - terraform released 'sensitive=true' feature for outputs
  - key vault RBAC propagation can take up to 10 minutes,
    which breaks terraform runs
@julie-ng
Copy link
Collaborator Author

Closed by c2d3d95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julie-ng julie-ng

Labels
terraform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julie-ng