Fix #153: Prevent stdout cutoff in Azure CLI versions #154
Conversation
src/main.ts
Outdated
| await exec.exec("curl", ["--location", "-s", "https://mcr.microsoft.com/v2/azure-cli/tags/list"], execOptions) | ||
| if (outStream && JSON.parse(outStream).tags) { | ||
| return JSON.parse(outStream).tags; | ||
| const response = await axios.get('https://mcr.microsoft.com/v2/azure-cli/tags/list'); |
There was a problem hiding this comment.
Since this action runs on Node 20, native fetch is available and wouldn't require an additional dependency.
There was a problem hiding this comment.
I am happy to try it out again from a branch on my workflow if that helps and you want to test the change.
EDIT: Running...
Sorry, our run will be delayed, because we just managed to deploy a bug and the workflow will run a lot longer than normal
There was a problem hiding this comment.
I ran against this branch once use fetch instead was merged and tests were green:
I don't see the warning anymore and the action appears to be working as expected on our self-hosted runners ✅
|
I'm not sure what happened here, but this fix does not work for me. It almost looks as if something got cached? I have no clue how the same python error can appear here if curl was eliminated? Is there any other instance of curl somewhere? |
|
Hi @jakub-lesniak-ikea, does it work for you with |
No it does not, that was the reason I started testing the |
|
@MoChilia can you tell me/us what the process and requirements are for approval to merge this? Do we still have to do something? |
|
@luc122c, @MeikeMertschFortum, @jakub-lesniak-ikea, it has now been merged into |
|
Thank you for your help |
Fix the issue #153, replace
curlwith aGETrequest to prevent stdout cutoff in Azure CLI versions, avoiding warnings in workflows.Close #153