Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Patch lb resources #477

Closed
wants to merge 2 commits into from
Closed

Patch lb resources #477

wants to merge 2 commits into from

Conversation

jvdhaterd
Copy link

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Added the missing lb resources to the local.networking.tf and variables.networking.tf

Does this introduce a breaking change

  • YES
  • NO

Testing

jvdhaterd added 2 commits June 16, 2023 13:51
@jvdhaterd
Update local.networking.tf adding missing lb resources
ee2d85f 
- lb_nat_pool
- lb_nat_rule                
- lb_outbound_rule 
- lb_probe                                      
- lb_rule
@jvdhaterd
Update variables.networking.tf adding lb resources
dada481 
- lb_nat_pool
- lb_nat_rule 
- lb_outbound_rule
- lb_probe
- lb_rule
@jvdhaterd
Copy link
Author

@microsoft-github-policy-service agree

@jvdhaterd jvdhaterd mentioned this pull request Jun 16, 2023
Open
@arnaudlh
Copy link
Member

Thanks for your PR @jvdhaterd! I will close this one as the networking was updated already in #476! Keep up the good contributions!

@arnaudlh arnaudlh closed this Jun 20, 2023
@jvdhaterd jvdhaterd deleted the patch-lb-resources branch June 20, 2023 06:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvdhaterd @arnaudlh