Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs, fix mockapi in auth scenarios #752

Merged

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Oct 14, 2024

microsoft/typespec PR microsoft/typespec#4740

Cadl Ranch Contribution Checklist:

  • I have written a scenario spec
  • I have meaningful @scenario names. Someone can look at the list of scenarios and understand what I'm covering.
  • I have written a mock API
  • I have used @scenarioDocs for extra scenario description and to tell people how to pass my mock api check.

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 2f9d5dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@azure-tools/cadl-ranch-api Minor
@azure-tools/cadl-ranch-specs Patch
@azure-tools/cadl-ranch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: the bug causes dash-board can't count coverage for invalid scenario for auth after Java/Python upgrade to latest cadl-ranch.
image

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but cn you fix the lint issues?

@weidongxu-microsoft
Copy link
Member Author

Sure. Cleaned up the lint error in the repo as well.

@weidongxu-microsoft weidongxu-microsoft merged commit 46e3022 into Azure:main Oct 16, 2024
9 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the specs_fix-auth-mockapi branch October 16, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants