Skip to content
This repository was archived by the owner on Jan 21, 2025. It is now read-only.

[cadl-ranch-*] Backport the server testing changes from typespec repository to cadl-ranch repository #741

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

sarangan12
Copy link
Contributor

@sarangan12 sarangan12 commented Oct 4, 2024

As part of cadl-ranch migration, several packages have been migrated from cadl-ranch repository to typespec repository. Now, the changes made to the typespec repository has to be backported to the cadl-ranch repository. This PR accomplishes that.

This PR consists of the following changes:

  1. Changes to the cadl-ranch-api & cadl-ranch packages have been migrated from the corresponding packages in the typespec repository. Except for 3 design changes, there is no bigger changes. These 3 changes are indicated in the PR Comments.
  2. Changes to the cadl-ranch-specs repository have been migrated from the corresponding package in the typespec repository. In addition to the endpoints in the typespec repository, the following folders have been migrated to new model:
  • client folder
  • azure folder
  • resiliency folder
  • payload/pageable folder

This change is done for 2 reasons. One, We do not want anyone to add new features in these folders using the old model. Second, I am planning to port these folders to the new package azure-http-specs for which I will create the PR shortly after this is merged.

I have already executed e2e scenarios and all validations are successful.

Note I have not made any major/minor version bumps for any of the 3 packages involved in this PR

Please review and approve the PR. Thanks

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 1494b41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@azure-tools/cadl-ranch-specs Patch
@azure-tools/cadl-ranch-api Patch
@azure-tools/cadl-ranch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sarangan12 sarangan12 changed the title Initial Commit [cadl-ranch-*] Backport the server testing changes from typespec repository to cadl-ranch repository Oct 4, 2024
Copy link
Contributor

@XiaofeiCao XiaofeiCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for azure/resource-manager.

So in the future, we should only update 4 azure scenarios(azure/client/resiliency/pageable) in this repo, and for others, we should be writing in microsoft/typespec?

github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Oct 9, 2024
)

1. As part of cadl-ranch migration, several packages have been migrated
from cadl-ranch repository to typespec repository. Once the split is
complete during the development, there were some changes that were
pushed in cadl-ranch repository. Those changes must be shifted back to
typespec repository.
2. Also, few changes are required in the packages to handle the azure
specific specs (These changes are added as part of the PR:
Azure/cadl-ranch#741).
3. In addition, I have created a new package called
`@azure-tools/azure-http-specs` has been created in the `typespec-azure`
repository. This package has only the azure specific specs. I have
tested the changes including the `pnpm test:e2e`. All validations are
successful. The changes in this PR will be required for creating the PR
for `@azure-tools/azure-http-specs` (which I will create once this PR is
merged).

Please review and approve this PR. Thanks
@timotheeguerin
Copy link
Member

LGTM for azure/resource-manager.

So in the future, we should only update 4 azure scenarios(azure/client/resiliency/pageable) in this repo, and for others, we should be writing in microsoft/typespec?

for a short period of time if you need to update teh typespec scenarios you should update it in both place.

For azure we are also moving them to the typespec-azure repo so you will need to update it there when that is done too.

When that is done we'll try to quickly rollout on having everyone use the new typespec and typespec-azure version instead so we can stop maintaining this repo

Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this

@sarangan12 sarangan12 enabled auto-merge (squash) October 10, 2024 17:15
@sarangan12 sarangan12 removed the request for review from xirzec October 10, 2024 17:44
@sarangan12 sarangan12 merged commit 352934c into Azure:main Oct 10, 2024
9 checks passed
github-merge-queue bot pushed a commit to Azure/typespec-azure that referenced this pull request Oct 11, 2024
…st Typespec (#1665)

This is a spin-off of PR Azure/cadl-ranch#741. A
new package `@azure-tools/azure-http-specs` has been created to handle
only the azure specific scenarios and the scenarios that are not
included in the `@typespec/http-specs` package.
Please review and approve the PR. 

Note:
1. The `test:e2e` script is working fine.
2. I have not deleted the `cadl-ranch-specs` folder under `e2e-tests`
folder and not modified the `e2e-tests.mjs` script.
tadelesh added a commit that referenced this pull request Oct 11, 2024
tadelesh added a commit that referenced this pull request Oct 11, 2024
* fix wrong mock api introduced by #741

* changeset
iscai-msft pushed a commit to Azure/typespec-azure that referenced this pull request Oct 16, 2024
…st Typespec (#1665)

This is a spin-off of PR Azure/cadl-ranch#741. A
new package `@azure-tools/azure-http-specs` has been created to handle
only the azure specific scenarios and the scenarios that are not
included in the `@typespec/http-specs` package.
Please review and approve the PR. 

Note:
1. The `test:e2e` script is working fine.
2. I have not deleted the `cadl-ranch-specs` folder under `e2e-tests`
folder and not modified the `e2e-tests.mjs` script.
swatkatz pushed a commit to swatkatz/typespec that referenced this pull request Nov 5, 2024
…crosoft#4637)

1. As part of cadl-ranch migration, several packages have been migrated
from cadl-ranch repository to typespec repository. Once the split is
complete during the development, there were some changes that were
pushed in cadl-ranch repository. Those changes must be shifted back to
typespec repository.
2. Also, few changes are required in the packages to handle the azure
specific specs (These changes are added as part of the PR:
Azure/cadl-ranch#741).
3. In addition, I have created a new package called
`@azure-tools/azure-http-specs` has been created in the `typespec-azure`
repository. This package has only the azure specific specs. I have
tested the changes including the `pnpm test:e2e`. All validations are
successful. The changes in this PR will be required for creating the PR
for `@azure-tools/azure-http-specs` (which I will create once this PR is
merged).

Please review and approve this PR. Thanks
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Dec 5, 2024
…st Typespec (Azure#1665)

This is a spin-off of PR Azure/cadl-ranch#741. A
new package `@azure-tools/azure-http-specs` has been created to handle
only the azure specific scenarios and the scenarios that are not
included in the `@typespec/http-specs` package.
Please review and approve the PR. 

Note:
1. The `test:e2e` script is working fine.
2. I have not deleted the `cadl-ranch-specs` folder under `e2e-tests`
folder and not modified the `e2e-tests.mjs` script.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants