-
Notifications
You must be signed in to change notification settings - Fork 34
[cadl-ranch-*] Backport the server testing changes from typespec repository to cadl-ranch repository #741
Conversation
🦋 Changeset detectedLatest commit: 1494b41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/cadl-ranch-specs/http/authentication/http/custom/mockapi.ts
Dismissed
Show dismissed
Hide dismissed
packages/cadl-ranch-specs/http/authentication/http/custom/mockapi.ts
Dismissed
Show dismissed
Hide dismissed
packages/cadl-ranch-specs/http/authentication/oauth2/mockapi.ts
Dismissed
Show dismissed
Hide dismissed
packages/cadl-ranch-specs/http/authentication/union/mockapi.ts
Dismissed
Show dismissed
Hide dismissed
packages/cadl-ranch-specs/http/azure/resource-manager/models/resources/mockapi.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for azure/resource-manager.
So in the future, we should only update 4 azure scenarios(azure/client/resiliency/pageable) in this repo, and for others, we should be writing in microsoft/typespec?
) 1. As part of cadl-ranch migration, several packages have been migrated from cadl-ranch repository to typespec repository. Once the split is complete during the development, there were some changes that were pushed in cadl-ranch repository. Those changes must be shifted back to typespec repository. 2. Also, few changes are required in the packages to handle the azure specific specs (These changes are added as part of the PR: Azure/cadl-ranch#741). 3. In addition, I have created a new package called `@azure-tools/azure-http-specs` has been created in the `typespec-azure` repository. This package has only the azure specific specs. I have tested the changes including the `pnpm test:e2e`. All validations are successful. The changes in this PR will be required for creating the PR for `@azure-tools/azure-http-specs` (which I will create once this PR is merged). Please review and approve this PR. Thanks
for a short period of time if you need to update teh typespec scenarios you should update it in both place. For azure we are also moving them to the typespec-azure repo so you will need to update it there when that is done too. When that is done we'll try to quickly rollout on having everyone use the new typespec and typespec-azure version instead so we can stop maintaining this repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge this
…st Typespec (#1665) This is a spin-off of PR Azure/cadl-ranch#741. A new package `@azure-tools/azure-http-specs` has been created to handle only the azure specific scenarios and the scenarios that are not included in the `@typespec/http-specs` package. Please review and approve the PR. Note: 1. The `test:e2e` script is working fine. 2. I have not deleted the `cadl-ranch-specs` folder under `e2e-tests` folder and not modified the `e2e-tests.mjs` script.
…st Typespec (#1665) This is a spin-off of PR Azure/cadl-ranch#741. A new package `@azure-tools/azure-http-specs` has been created to handle only the azure specific scenarios and the scenarios that are not included in the `@typespec/http-specs` package. Please review and approve the PR. Note: 1. The `test:e2e` script is working fine. 2. I have not deleted the `cadl-ranch-specs` folder under `e2e-tests` folder and not modified the `e2e-tests.mjs` script.
…crosoft#4637) 1. As part of cadl-ranch migration, several packages have been migrated from cadl-ranch repository to typespec repository. Once the split is complete during the development, there were some changes that were pushed in cadl-ranch repository. Those changes must be shifted back to typespec repository. 2. Also, few changes are required in the packages to handle the azure specific specs (These changes are added as part of the PR: Azure/cadl-ranch#741). 3. In addition, I have created a new package called `@azure-tools/azure-http-specs` has been created in the `typespec-azure` repository. This package has only the azure specific specs. I have tested the changes including the `pnpm test:e2e`. All validations are successful. The changes in this PR will be required for creating the PR for `@azure-tools/azure-http-specs` (which I will create once this PR is merged). Please review and approve this PR. Thanks
…st Typespec (Azure#1665) This is a spin-off of PR Azure/cadl-ranch#741. A new package `@azure-tools/azure-http-specs` has been created to handle only the azure specific scenarios and the scenarios that are not included in the `@typespec/http-specs` package. Please review and approve the PR. Note: 1. The `test:e2e` script is working fine. 2. I have not deleted the `cadl-ranch-specs` folder under `e2e-tests` folder and not modified the `e2e-tests.mjs` script.
As part of
cadl-ranch
migration, several packages have been migrated fromcadl-ranch
repository totypespec
repository. Now, the changes made to thetypespec
repository has to be backported to thecadl-ranch
repository. This PR accomplishes that.This PR consists of the following changes:
cadl-ranch-api
&cadl-ranch
packages have been migrated from the corresponding packages in thetypespec
repository. Except for 3 design changes, there is no bigger changes. These 3 changes are indicated in the PR Comments.cadl-ranch-specs
repository have been migrated from the corresponding package in thetypespec
repository. In addition to the endpoints in thetypespec
repository, the following folders have been migrated to new model:This change is done for 2 reasons. One, We do not want anyone to add new features in these folders using the old model. Second, I am planning to port these folders to the new package
azure-http-specs
for which I will create the PR shortly after this is merged.I have already executed e2e scenarios and all validations are successful.
Note I have not made any major/minor version bumps for any of the 3 packages involved in this PR
Please review and approve the PR. Thanks