fix ARM scenario names #714
Conversation
🦋 Changeset detectedLatest commit: 9ee03d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
XiaofeiCao
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft,
tadelesh and
timotheeguerin
as code owners
...s/cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/main.tsp
Outdated
Show resolved
Hide resolved
...s/cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/main.tsp
Outdated
Show resolved
Hide resolved
|
@iscai-msft I've renamed the namespace according to #703 (comment) I removed the extra Let me know your thoughts. |
There was a problem hiding this comment.
thank you for all of your work @XiaofeiCao, I think this definitely is almost there. @timotheeguerin if you could take a look with your ARM knowledge, that would be great. Thank you so much!
|
@XiaofeiCao is this PR ready to re-review? |
Yes, please! Would like a re-review for this PR, since it's required for future ARM test cases. I added breaking change note in changeset, let me know if it looks good. |
There was a problem hiding this comment.
Thanks @XiaofeiCao this looks great! Can you make sure @timotheeguerin approves first, and that folks in shanghai are aware of the breaking change? After that is done, should be good to merge. Thanks again for all of your changes and all the work you've put into this, it looks great
Yes, shanghai folks are informed of this breaking change. Thanks a lot for your suggestions! |
Yeah, regened and tested: microsoft/typespec#4717 |
…1712) - origin: Azure/cadl-ranch#714 - Fixed singleton mockapi.ts. Location is not updatable. Tested locally.
…zure#1712) - origin: Azure/cadl-ranch#714 - Fixed singleton mockapi.ts. Location is not updatable. Tested locally.
Related comment: #701 (comment)
Shouldn't affect existing generated SDK code. Verified for Java, codegen PR: microsoft/typespec#4717
May affect existing coverage data in dashboard, though should be auto-updated after each SDK's generator CI runs.
Cadl Ranch Contribution Checklist:
@scenarionames. Someone can look at the list of scenarios and understand what I'm covering.@scenarioDocs for extra scenario description and to tell people how to pass my mock api check.