Skip to content
This repository has been archived by the owner on Jan 21, 2025. It is now read-only.

Remove inapplicable logic for dashboard #706

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented Aug 22, 2024

As titled.

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 40982c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@azure-tools/cadl-ranch-coverage-sdk Patch
@azure-tools/cadl-ranch-dashboard Patch
@azure-tools/cadl-ranch Patch
@azure-tools/cadl-ranch-specs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iscai-msft
Copy link
Contributor

@pshao25 can you clarify why you're removing this code? Is it because we won't get report docs with the name ${generatorName}/reports/${index.version}.json anymore?

@pshao25
Copy link
Member Author

pshao25 commented Aug 23, 2024

@pshao25 can you clarify why you're removing this code? Is it because we won't get report docs with the name ${generatorName}/reports/${index.version}.json anymore?

Correct.

Those days when we only have one mode "azure", the reports store there. But now we have two modes, "azure" and "non-azure", the reports are stored in ${generatorName}/reports/${index.version}/${generatorMode}.json.

We currently have some problem in the dashboard by the current logic "if old path exists then retrieve from old path, else retrieve from new path" because we somehow pushed an old version by accident. Since we don't need the old path, it is safe to remove. What's more I think we could also remove all the data in ${generatorName}/reports/${index.version}.json unless we want an archive.

@iscai-msft iscai-msft enabled auto-merge (squash) August 23, 2024 17:04
@iscai-msft iscai-msft merged commit cd9fdd6 into Azure:main Aug 23, 2024
9 checks passed
@pshao25 pshao25 deleted the dashboardFix branch August 26, 2024 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants