Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test in Versioning/Removed #627

Merged
merged 38 commits into from
Sep 26, 2024
Merged

Conversation

mcgallan
Copy link
Member

@mcgallan mcgallan commented Jul 9, 2024

The purpose of this PR is to migrate the tests from the test.project folder in autorest.csharp to the cadl branch, specifically referring to the tests in latestVersion.typeSpec as detailed in the .changeset.
related issue: Azure/autorest.csharp#4850
Azure/autorest.csharp#4853
Azure/autorest.csharp#4856
The content of these three projects is identical and can be handled together.

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 3f1d99b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@azure-tools/cadl-ranch-specs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcgallan mcgallan changed the title Add Lest in Versioning/Removed Add Test in Versioning/Removed Jul 9, 2024
@mcgallan mcgallan marked this pull request as ready for review July 17, 2024 06:47
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mcgallan Make sure we can generate 3 test projects from this case, e.g. api-version should be v1, beta, v2 respectively.

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me, once we've moved to more ABA testing. @tadelesh can you confirm the new test makes sense with the existing scenarios? Thanks so much!

Copy link
Member

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm little bit confused of what this test is trying to achieve?

packages/cadl-ranch-specs/http/versioning/removed/main.tsp Outdated Show resolved Hide resolved
@tadelesh
Copy link
Member

please refine the version name

@mcgallan mcgallan merged commit 92f3c4d into Azure:main Sep 26, 2024
9 checks passed
pshao25 added a commit that referenced this pull request Sep 30, 2024
pshao25 added a commit that referenced this pull request Sep 30, 2024
* Revert "Add Test in Versioning/Removed (#627)"

This reverts commit 92f3c4d.

* update

---------

Co-authored-by: Pan Shao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants