-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Test in Versioning/Removed #627
Conversation
🦋 Changeset detectedLatest commit: 3f1d99b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @mcgallan Make sure we can generate 3 test projects from this case, e.g. api-version
should be v1
, beta
, v2
respectively.
…-ranch into 0709-latestversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me, once we've moved to more ABA testing. @tadelesh can you confirm the new test makes sense with the existing scenarios? Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm little bit confused of what this test is trying to achieve?
please refine the version name |
* Revert "Add Test in Versioning/Removed (#627)" This reverts commit 92f3c4d. * update --------- Co-authored-by: Pan Shao <[email protected]>
The purpose of this PR is to migrate the tests from the test.project folder in autorest.csharp to the cadl branch, specifically referring to the tests in latestVersion.typeSpec as detailed in the .changeset.
related issue: Azure/autorest.csharp#4850
Azure/autorest.csharp#4853
Azure/autorest.csharp#4856
The content of these three projects is identical and can be handled together.