This repository was archived by the owner on Jan 21, 2025. It is now read-only.
Tests for ARM, adds ManagedIdentityTrackedResource #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaofeiCao
reviewed
Jun 27, 2024
XiaofeiCao
reviewed
Jun 27, 2024
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
XiaofeiCao
reviewed
Jun 27, 2024
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
XiaofeiCao
reviewed
Jun 27, 2024
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
XiaofeiCao
reviewed
Jun 27, 2024
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
|
Lack one scenario: updateWithUserAssignedOnly |
The multiple |
v-hongli1
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft,
tadelesh and
timotheeguerin
as code owners
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/azure/arm/models/common-types/managed-identity/identity.tsp
Outdated
Show resolved
Hide resolved
XiaofeiCao
reviewed
Jul 3, 2024
...s/cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/main.tsp
Outdated
Show resolved
Hide resolved
XiaofeiCao
reviewed
Jul 3, 2024
...s/cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/main.tsp
Outdated
Show resolved
Hide resolved
|
@weidongxu-microsoft none (I mean literally none) of the LRO test are supported in .net, because we have a troublesome known issue. Therefore I cannot review. |
what are you talking about... I asked author to use Sync, not Async. |
Didn't notice that. @mcgallan could you have a try and prepare at .net side?
|
pshao25
reviewed
Jul 3, 2024
...cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/mockapi.ts
Outdated
Show resolved
Hide resolved
pshao25
reviewed
Jul 3, 2024
...cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/mockapi.ts
Outdated
Show resolved
Hide resolved
v-hongli1
force-pushed
the
issues#605_reopen
branch
from
502ff23 to
0159000
Compare
weidongxu-microsoft
approved these changes
Jul 9, 2024
|
LGTM. Please wait for approval from another language. |
XiaofeiCao
approved these changes
Jul 11, 2024
msyyc
approved these changes
Jul 11, 2024
weidongxu-microsoft
approved these changes
Jul 11, 2024
...cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/mockapi.ts
Outdated
Show resolved
Hide resolved
...cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/mockapi.ts
Outdated
Show resolved
Hide resolved
...s/cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/main.tsp
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cadl Ranch Contribution Checklist:
Supported scenarios
ManagedIdentityTrackedResourc
I have written a scenario spec
I have meaningful
@scenarionames. Someone can look at the list of scenarios and understand what I'm covering.I have written a mock API
I have used
@scenarioDocs for extra scenario description and to tell people how to pass my mock api check.