Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for ARM, adds TrackedResource #588

Merged
merged 23 commits into from
Jun 18, 2024
Merged

Tests for ARM, adds TrackedResource #588

merged 23 commits into from
Jun 18, 2024

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented May 28, 2024 •
edited
Loading

Cadl Ranch Contribution Checklist:

Supported scenarios

  • TopLevelTrackedResource

    • createOrReplace(put)
    • update(patch)
    • get
    • delete
    • listBySubscription
    • listByResourceGroup

  • NestedProxyResource

    • createOrReplace(put)
    • update(patch)
    • get
    • delete
    • listByParent

  • I have written a scenario spec

  • I have meaningful @scenario names. Someone can look at the list of scenarios and understand what I'm covering.

  • I have written a mock API

  • I have used @scenarioDocs for extra scenario description and to tell people how to pass my mock api check.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 96ad5d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@azure-tools/cadl-ranch-specs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

timotheeguerin
timotheeguerin reviewed May 28, 2024
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
@XiaofeiCao XiaofeiCao marked this pull request as ready for review June 4, 2024 06:02
@XiaofeiCao XiaofeiCao requested a review from tadelesh as a code owner June 4, 2024 06:02
@qiaozha
Copy link
Member

qiaozha commented Jun 4, 2024

Is there any template for tenant level resource?

@XiaofeiCao
Copy link
Contributor Author

Is there any template for tenant level resource?

No, not yet. This PR is kinda like PoC and only includes TopLevelTrackedResource and ProxyResource. We could add them afterwards.

@tadelesh tadelesh merged commit 8b42129 into Azure:main Jun 18, 2024
7 checks passed
@XiaofeiCao XiaofeiCao mentioned this pull request Jun 25, 2024
Closed
@XiaofeiCao XiaofeiCao mentioned this pull request Aug 12, 2024
Open
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin left review comments

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@tadelesh tadelesh tadelesh approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XiaofeiCao @qiaozha @timotheeguerin @tadelesh @weidongxu-microsoft