Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames and refactoring before private ACR completions work #16323

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Feb 3, 2025

Intended to make the next PR easier to read. Mostly renames, plus some test infrastructure improvements. There should be little or no production impact.

Microsoft Reviewers: Open in CodeFlow

@StephenWeatherford StephenWeatherford force-pushed the sw/pre-acr-completions branch 2 times, most recently from f667963 to a4bc3bb Compare February 3, 2025 23:34
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test this change out locally with the following install scripts (Action run 13147439151)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 13147439151
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 13147439151"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 13147439151
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 13147439151"

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Dotnet Test Results

    78 files   -     39      78 suites   - 39   32m 32s ⏱️ - 19m 16s
11 729 tests  -     13  11 729 ✅  -     13  0 💤 ±0  0 ❌ ±0 
27 216 runs   - 13 603  27 216 ✅  - 13 603  0 💤 ±0  0 ❌ ±0 

Results for commit 3a875fa. ± Comparison against base commit 6f7bd87.

This pull request removes 1809 and adds 625 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Cli.IntegrationTests.UseRecentModuleVersionsIntegrationTests ‑ IfNoRestoreSpecified_ThenShouldNotDownloadMetadata_AndShouldFailBecauseNoCache
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�ӽ
� \u0010\u0007p�>�O`��i2d��W�6�\u000fbJbh���{\u0019
\u001d\u0012��I������T�"ٹ~[�CٴBC�&��M\u0012����\u0000\u0010\u0018�\u0017ɤE�a��}�\u0011]\u001b\C�,q�\u000fJ3�©*\u000b�*�\u0012L�"W
��
���5�W\u0017�E�/��yqnk?4TS
k_4\u001a����z�O��2e�-JZh��\u000fHy�d������=A\u0014EQ��'Q���\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Խ
�0\u0010\u0000��>E�\u0003Ĥ�O#tw\u0011\|�؞X��4\u0015
⻛\u000e����\u001f�|�\u000c��\\u0012.d�7�\u0016L\u0006�%��pM�ب#9�]�0�\u0010So\u0014Q%�D\u0008��W��n\u001bS�R���\u0007�16M^@�T\u0014+�d,���Қ�\,\u001d�1�+Ӝ��̠%\u0017{+��b(}�cz\u0003>�7�\u0015}��\u001aq��\u0000A�\u0010R *�\u0019�Yz������C	m\u0005i\u0003�\u000e�#��\u0006����s��<���\u0000Yj�[\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��A\u000b�0\u0014\u0000���\u0015�\u001f07��4�\u0010t�\u0008\u000b��1r��\u0016j �盇�tQ\u000b�\u0007��=���{�ݩf�U�ˊp\u0016z.AC�\u0006p޹�b\"&_(�R\u0008@\u00087�W��^ժ4�Lq�\u000f�\u0002��,�\u0011�~ )�@�\u0010|\u0008<��ة/�B|S�9ʊT7�R]�6=�K��5�\u001e��\u001b�>�?�823@P�\u0004\u0008DA��Ɠ����É��b\u0013/���6q��L�o�dY�e��	g4й\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Խ
�0\u0010\u0000��>E�\u0003�I�sV� 8X�*\u0008�\u0012l�
��V(�\uda58\udcf8���G0\u001fd�\u001d܅pGܽ�׉���$\r�\u0012�7j(!Z�\u001bL\u0000b�F\u0011\u0005)=�p�{'-\u001ee�\u000b��\u0018�~�7ǺJ�$`��@�T@\u0018x�K53�sW�����K��qR�ky˛��+}�gZ\u001d>�7\�o�O=��\u000e��\u001c\u000e���J��\u001fe&�|��N\u0018\u001d��pu�\u001cv���f\u0003OݓeY�5�\u0017I��\u0017\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��K
� \u0010\u0006`�=�'0�:����\u0015�
�ALɃ\u0006J�^�(t��M�\u0014�\u0007n\u001c\u0006G�_d;�o\u000b�(�FhԐ	67\u0019YcF�\u0007���^$��\u0006\u0019��쓌���q�%��A�qߞ�"\u0007Ҏ�*�\u0015J�CG�X�Oր_}{̻p	�-�sS����jX��ɨ��}�O��R10�2\u001eM6�\u001f0�/��?�����\u0004I�$�\u001a��\u0016\u0002(\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��K
�0\u0010\u0006�=E�\u0001bҼZ�{7�\u001b\u000f\u0010�\u0011+���BA���Bܴ��C0\u001fd�\u0019Ȅ�����݂ɠ��K��\u0004��:J���\u000e\u0013\u001a1�F\u0011�R�\u0008�v�Iz�mcj7�\u001cg��0¦�\u000bH�摦L*MX\u001c������C5\u0016��4�$/3h���ʮ�\u0018j_��ހ��MwƷ�S.��\u0003$u�k���J��ϒ�?��\u0003\u0007�\u0012�
�\u0006�\u001d\u0014G��
>����ҳy��y�y\u0001ʙE�\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Repository_not_found_in_registry (ArtifactRegistryAddress { RegistryAddress = mcr.microsoft.com, RepositoryPath = unknown/path/az, ExtensionVersion = 0.0.0-placeholder, RegistryUri = https://mcr.microsoft.com/ },Azure.RequestFailedException: The artifact does not exist in the registry.,[(BCP192, Error, Unable to restore the artifact with reference "br:mcr.microsoft.com/unknown/path/az:0.0.0-placeholder": The artifact does not exist in the registry.)])
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Repository_not_found_in_registry (ArtifactRegistryAddress { RegistryAddress = unknown.registry.azurecr.io, RepositoryPath = bicep/extensions/az, ExtensionVersion = 0.0.0-placeholder, RegistryUri = https://unknown.registry.azurecr.io/ },System.AggregateException: Retry failed after 4 tries. Retry settings can be adjusted in ClientOptions.Retry or by configuring a custom retry policy in ClientOptions.RetryPolicy. (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)),[(BCP192, Error, Unable to restore the artifact with reference "br:unknown.registry.azurecr.io/bicep/extensions/az:0.0.0-placeholder": Retry failed after 4 tries. Retry settings can be adjusted in ClientOptions.Retry or by configuring a custom retry policy in ClientOptions.RetryPolicy. (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)) (No such host is known. (unknown.registry.azurecr.io:443)))])
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createArray(1, 2, 3)","array","[
  1
  2
  3
]")
…

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford merged commit 5f03b3b into main Feb 5, 2025
47 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/pre-acr-completions branch February 5, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants