File I/O Abstraction: Replace IFileResolver.TryAcquireFileLock
#15826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenglol
changed the title
IFileResolver.TryAcquireFileLockIFileResolver.TryAcquireFileLock
|
Test this change out locally with the following install scripts (Action run 12290549161) VSCode
Azure CLI
|
Dotnet Test Results 78 files - 39 78 suites - 39 30m 22s ⏱️ - 20m 42s Results for commit 8a124ec. ± Comparison against base commit c730403. This pull request removes 1842 and adds 633 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Copilot reviewed 53 out of 68 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- src/Bicep.Cli.IntegrationTests/packages.lock.json: Language not supported
- src/Bicep.Cli.UnitTests/packages.lock.json: Language not supported
- src/Bicep.Cli/packages.lock.json: Language not supported
- src/Bicep.Core.IntegrationTests/packages.lock.json: Language not supported
- src/Bicep.Core.Samples/packages.lock.json: Language not supported
- src/Bicep.Core.UnitTests/BicepTestConstants.cs: Evaluated as low risk
- src/Bicep.Core.UnitTests/Features/FeatureProviderOverrides.cs: Evaluated as low risk
- src/Bicep.Core.UnitTests/Features/OverriddenFeatureProvider.cs: Evaluated as low risk
- src/Bicep.Core.UnitTests/Features/FeatureProviderTests.cs: Evaluated as low risk
- src/Bicep.Core.UnitTests/ApiVersion/ApiVersionProviderTests.cs: Evaluated as low risk
- src/Bicep.Core.IntegrationTests/SourceArchiveTests.cs: Evaluated as low risk
- src/Bicep.Core.UnitTests/Assertions/OciModuleRegistryAssertions.cs: Evaluated as low risk
- src/Bicep.Core.UnitTests/Registry/CachedModules.cs: Evaluated as low risk
- src/Bicep.Cli.IntegrationTests/RestoreCommandTests.cs: Evaluated as low risk
- src/Bicep.Core.IntegrationTests/ExtensionRegistryTests.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
src/Bicep.Core.IntegrationTests/RegistryTests.cs:45
- [nitpick] The variable 'badCacheDirectory' is reassigned to a file handle, which can be confusing. Consider using a different variable name for the file handle, such as 'badCacheFileHandle'.
badCacheDirectory = badCacheDirectory.GetDirectory("file.txt");
majastrz
reviewed
Dec 12, 2024
| { | ||
| if (!OperatingSystem.IsWindows()) | ||
| { | ||
| this.FileSystem.File.SetUnixFileMode(this.Uri.GetFileSystemPath(), UnixFileMode.UserRead | UnixFileMode.UserWrite | UnixFileMode.UserExecute); |
There was a problem hiding this comment.
It's not, but chmod 700 seems to be common. Also, the original code has the UserWrite flag, so keeping it just in case.
majastrz
reviewed
Dec 12, 2024
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="System.IO.Abstractions" Version="21.1.3" /> | |||
| <PackageReference Include="System.Memory.Data" Version="6.0.0" /> | |||
There was a problem hiding this comment.
Good question...the package was added by VS automatically via completion. Not sure why the old version is used. Let me bump the version.
There was a problem hiding this comment.
Ah it's because Azure.Core has a transitive dependency on System.Memory.Data 6.0.0, so VS choosed the local version. Let's keep the current version to avoid any incompatible issues since Azure.Core is used by Bicep.Core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ongoing file I/O abstraction migration, this PR removes
IFileResolver.TryAcquireFileLockand transitions it to the new file I/O API. The updates, including changes toIFeatureProvider,*ArtifactRegistry, and several related tests, are inevitable side effects of what initially seemed like a straightforward update.Microsoft Reviewers: Open in CodeFlow